klcopp commented on a change in pull request #1501:
URL: https://github.com/apache/hive/pull/1501#discussion_r489250118
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -445,14 +446,23 @@ public static boolean isCompactionTable(Properties
tblProperties) {
}
/**
- * Determine if a table is used during query based compaction.
+ * Determine if a table is used during query based compaction for CRUD
tables.
* @param parameters table properties map
* @return true, if the parameters contains {@link
AcidUtils#COMPACTOR_TABLE_PROPERTY}
*/
public static boolean isCompactionTable(Map<String, String> parameters) {
return Boolean.valueOf(parameters.getOrDefault(COMPACTOR_TABLE_PROPERTY,
"false"));
}
+ /**
+ * Determine if a table is used during query based compaction for MM
insert-only tables.
+ * @param parameters table properties map
+ * @return true, if the parameters contains {@link
AcidUtils#MM_COMPACTOR_TABLE_PROPERTY}
+ */
+ public static boolean isMmCompactionTable(Map<String, String> parameters) {
Review comment:
isCompactionTable logically would be true for both full acid and mm
tables, but until now we've only used it to mark tables used for compacting
full acid tables. AFAIK we don't want to apply the operations we do on full
acid compaction tables to mm compaction tables.
I could rename isCompactionTable() to isFullAcidCompactionTable() for easier
reading, would that do?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
