kgyrtkirk commented on a change in pull request #1497:
URL: https://github.com/apache/hive/pull/1497#discussion_r497613491
##########
File path: ql/src/test/queries/clientnegative/strict_numeric_to_timestamp.q
##########
@@ -0,0 +1,2 @@
+set hive.strict.timestamp.conversion=true;
+select cast(123 as timestamp);
Review comment:
I've added a few more tests; and I've also added one with a `struct` -
however I don't really feel it that much different from the others (the way the
check works) - I might be too much "inside the box"; so if you have any
suggestions what tests to add - please let me know
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
