kgyrtkirk commented on a change in pull request #1497:
URL: https://github.com/apache/hive/pull/1497#discussion_r498150259
##########
File path: ql/src/test/queries/clientnegative/strict_numeric_to_timestamp.q
##########
@@ -0,0 +1,2 @@
+set hive.strict.timestamp.conversion=true;
+select cast(123 as timestamp);
Review comment:
good catch! I didn't expected that `=` will work without casting - but
since its using the converters it could avoid these checks.
I considered moving the check into the converters - however that would
involved getting a `SessionState` in serde codes...so I instead added 1 more
check to cover all the comparisions. Generic binary operator seem to don't
auto-convert things ; `+` was complaining about adding a timestamp and an
integer - so I think we are good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
