aasha commented on a change in pull request #1550:
URL: https://github.com/apache/hive/pull/1550#discussion_r499535302
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/plan/ReplTxnWork.java
##########
@@ -92,6 +120,18 @@ public ReplTxnWork(String dbName, String tableName,
List<String> partNames,
this.operation = type;
}
+ public ReplTxnWork(String dbName, String tableName, List<String> partNames,
Review comment:
have 2 constructors. one with the dumpDirectory and metricCollector and
one without. That way you don't need to change existing code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
