aasha commented on a change in pull request #1550:
URL: https://github.com/apache/hive/pull/1550#discussion_r507575660
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosExternalTables.java
##########
@@ -1324,5 +1331,18 @@ private String relativeExtInfoPath(String dbName) {
return File.separator + dbName.toLowerCase() + File.separator +
FILE_NAME;
}
}
-
+
+ private Path getNonRecoverablePath(Path dumpDir, String dbName) throws
IOException {
Review comment:
Need to be utility method. This is part of other tests also
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AckTask.java
##########
@@ -45,9 +46,10 @@ public int execute() {
Path ackPath = work.getAckFilePath();
Utils.create(ackPath, conf);
LOG.info("Created ack file : {} ", ackPath);
- } catch (SemanticException e) {
+ } catch (Exception e) {
setException(e);
- return ErrorMsg.getErrorMsg(e.getMessage()).getErrorCode();
+ return ReplUtils.handleException(true, e,
work.getAckFilePath().getParent().getParent().toString(),
Review comment:
can this be null work.getAckFilePath().getParent().getParent()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
