nrg4878 commented on a change in pull request #1578:
URL: https://github.com/apache/hive/pull/1578#discussion_r505727119
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
##########
@@ -13212,7 +13212,7 @@ private void updateDefaultTblProps(Map<String, String>
source, Map<String, Strin
retValue.put(hive_metastoreConstants.TABLE_TRANSACTIONAL_PROPERTIES,
TransactionalValidationListener.INSERTONLY_TRANSACTIONAL_PROPERTY);
}
- if (makeAcid || isTransactional) {
+ if (makeAcid || isTransactional || (isManaged && !makeInsertOnly)) {
Review comment:
so isManaged and isTransactional cannot be true at the time.
create managed table ... -->isManaged=true
create transactional table -->isTransactional=true
with either of the above set, makeInsertOnly can be true or false. This is
the server side setting not driven by the query syntax.
so create managed creates "insert_only" acid table if
"hive.create.as.insert.only"=true otherwise it creates a full acid table
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
