nrg4878 commented on a change in pull request #1578: URL: https://github.com/apache/hive/pull/1578#discussion_r505958125
########## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java ########## @@ -13194,16 +13194,16 @@ private void updateDefaultTblProps(Map<String, String> source, Map<String, Strin } } - boolean makeInsertOnly = !isTemporaryTable && (isManaged && HiveConf.getBoolVar( - conf, ConfVars.HIVE_CREATE_TABLES_AS_INSERT_ONLY)); - boolean makeAcid = !isTemporaryTable && !makeInsertOnly && makeAcid(); + boolean makeInsertOnly = !isTemporaryTable && HiveConf.getBoolVar( + conf, ConfVars.HIVE_CREATE_TABLES_AS_INSERT_ONLY); + boolean makeAcid = !isTemporaryTable && makeAcid(); Review comment: correct .. no change here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org