zeroflag commented on a change in pull request #1542:
URL: https://github.com/apache/hive/pull/1542#discussion_r512060372
##########
File path:
hplsql/src/main/java/org/apache/hive/hplsql/functions/FunctionDatetime.java
##########
@@ -36,20 +36,20 @@ public FunctionDatetime(Exec e) {
* Register functions
*/
@Override
- public void register(Function f) {
- f.map.put("DATE", new FuncCommand() { public void
run(HplsqlParser.Expr_func_paramsContext ctx) { date(ctx); }});
- f.map.put("FROM_UNIXTIME", new FuncCommand() { public void
run(HplsqlParser.Expr_func_paramsContext ctx) { fromUnixtime(ctx); }});
- f.map.put("NOW", new FuncCommand() { public void
run(HplsqlParser.Expr_func_paramsContext ctx) { now(ctx); }});
- f.map.put("TIMESTAMP_ISO", new FuncCommand() { public void
run(HplsqlParser.Expr_func_paramsContext ctx) { timestampIso(ctx); }});
- f.map.put("TO_TIMESTAMP", new FuncCommand() { public void
run(HplsqlParser.Expr_func_paramsContext ctx) { toTimestamp(ctx); }});
- f.map.put("UNIX_TIMESTAMP", new FuncCommand() { public void
run(HplsqlParser.Expr_func_paramsContext ctx) { unixTimestamp(ctx); }});
+ public void register(BuiltinFunctions f) {
+ f.map.put("DATE", this::date);
Review comment:
This is a general issue, many things are package private. We can
refactor that little by little.
.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
