zeroflag commented on a change in pull request #1542:
URL: https://github.com/apache/hive/pull/1542#discussion_r512061184
##########
File path: hplsql/src/main/java/org/apache/hive/hplsql/Exec.java
##########
@@ -799,30 +801,35 @@ Integer init(String[] args) throws Exception {
select = new Select(this);
stmt = new Stmt(this);
converter = new Converter(this);
-
- function = new Function(this);
- new FunctionDatetime(this).register(function);
- new FunctionMisc(this).register(function);
- new FunctionString(this).register(function);
- new FunctionOra(this).register(function);
+
+ builtinFunctions = new BuiltinFunctions(this);
+ new FunctionDatetime(this).register(builtinFunctions);
+ new FunctionMisc(this).register(builtinFunctions);
+ new FunctionString(this).register(builtinFunctions);
+ new FunctionOra(this).register(builtinFunctions);
+ if ("hms".equalsIgnoreCase(System.getProperty("hplsql.storage"))) {
+ function = new HmsFunction(this,
getMsc(System.getProperty("hplsq.metastore.uris", "thrift://localhost:9083")),
builtinFunctions);
Review comment:
This part is removed from subsequent patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
