zeroflag commented on a change in pull request #1633: URL: https://github.com/apache/hive/pull/1633#discussion_r528663855
########## File path: hplsql/src/main/java/org/apache/hive/hplsql/executor/JdbcQueryExecutor.java ########## @@ -0,0 +1,101 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.hive.hplsql.executor; + +import java.sql.ResultSet; +import java.sql.ResultSetMetaData; +import java.sql.SQLException; +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; + +import org.antlr.v4.runtime.ParserRuleContext; +import org.apache.hive.hplsql.Exec; +import org.apache.hive.hplsql.Query; + +public class JdbcQueryExecutor implements QueryExecutor { + private final Exec exec; + + public JdbcQueryExecutor(Exec exec) { + this.exec = exec; + } + + @Override + public QueryResult executeQuery(String sql, ParserRuleContext ctx) { + String conn = exec.getStatementConnection(); + Query query = exec.executeQuery(ctx, new Query(sql), conn); + ResultSet resultSet = query.getResultSet(); + if (resultSet == null) { // offline mode + return new QueryResult(null, () -> new Metadata(Collections.emptyList()), query.getException()); + } else { + return new QueryResult(new JdbcRowResult(resultSet), () -> metadata(resultSet), query.getException()); + } + } + + private static Metadata metadata(ResultSet resultSet) { + try { + ResultSetMetaData meta = resultSet.getMetaData(); + List<ColumnMeta> colMetas = new ArrayList<>(); + for (int i = 1; i <= meta.getColumnCount(); i++) { + colMetas.add(new ColumnMeta( + meta.getColumnName(i), meta.getColumnTypeName(i), meta.getColumnType(i))); + } + return new Metadata(colMetas); + } catch (SQLException e) { + throw new QueryException(e); + } + } + + private static class JdbcRowResult implements RowResult { + private final ResultSet resultSet; + + private JdbcRowResult(ResultSet resultSet) { + this.resultSet = resultSet; + } + + @Override + public boolean next() { + try { + return resultSet.next(); + } catch (SQLException e) { + throw new QueryException(e); + } + } + + @Override + public <T> T get(int columnIndex, Class<T> type) { + try { + return resultSet.getObject(columnIndex, type); Review comment: Right, this is off by one. the Jdbc adaptor was added for compatibility, I'm not sure for how long we'll want to support it but I fixed indexing. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
