zeroflag commented on a change in pull request #1633:
URL: https://github.com/apache/hive/pull/1633#discussion_r528666168
##########
File path: service/src/java/org/apache/hive/service/cli/operation/Operation.java
##########
@@ -88,8 +89,14 @@ protected Operation(HiveSession parentSession, OperationType
opType) {
}
protected Operation(HiveSession parentSession,
- Map<String, String> confOverlay, OperationType opType) {
+ Map<String, String> confOverlay, OperationType opType) {
+ this(parentSession, confOverlay, opType, false);
+ }
+
+ protected Operation(HiveSession parentSession,
+ Map<String, String> confOverlay, OperationType opType, boolean embedded)
{
Review comment:
The SqlOperation is called with embedded=true when it is instantiated
from a running hplsql script.
```
new SQLOperation(parentSession, statement, confOverlay, runAsync,
queryTimeout, hplSqlMode());
```
Could elaborate more on that idea of having it as a first class citizen?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
