deniskuzZ commented on a change in pull request #1688:
URL: https://github.com/apache/hive/pull/1688#discussion_r530250594



##########
File path: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
##########
@@ -670,6 +725,8 @@ public OpenTxnsResponse openTxns(OpenTxnRequest rqst) 
throws MetaException {
 
       assert txnIds.size() == numTxns;
 
+      addTxnToMinHistoryLevel(dbConn, txnIds, minOpenTxnId);

Review comment:
       why not to put this under above useMinHistoryLevel check? or even embed 
getMinOpenTxnIdWaterMark(dbConn) inside of addTxnToMinHistoryLevel?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to