pvargacl commented on a change in pull request #1688:
URL: https://github.com/apache/hive/pull/1688#discussion_r534357150
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java
##########
@@ -385,6 +391,26 @@ public static String queryToString(Configuration conf,
String query, boolean inc
return sb.toString();
}
+ /**
+ * This is only for testing, it does not use the connectionPool from
TxnHandler!
+ * @param conf
+ * @param query
+ * @throws Exception
+ */
+ @VisibleForTesting
+ public static void executeUpdate(Configuration conf, String query)
Review comment:
Well, this class is a test utility.
/**
* Utility methods for creating and destroying txn database/schema, plus
methods for
* querying against metastore tables.
* Placed here in a separate class so it can be shared across unit tests.
*/
public final class TxnDbUtil
The problem is more like getEpochFn and executeQueriesInBatchNoCount was
added to this class, those are production code. I know it would be nicer if it
would be in a test package, but then it would be harder to use in 5 different
projects
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
