miklosgergely edited a comment on pull request #1756: URL: https://github.com/apache/hive/pull/1756#issuecomment-753538962
@belugabehr I've fixed most of the issues that you've mentioned. I was mainly focused on putting the code to it's proper location, in a manageable structure, and it was great that you've looked at the code thoroughly, finding these suboptimal solutions, thank you for that. Regarding the append().append() like issues: these commands are not performance critical (it is not realistic that someone would like to issue 100s of show / desc commands per sec), so in these cases I choose code readability over performance. Still I've fixed those where LINE_DELIM is appended, as it doesn't decrease readability. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
