belugabehr commented on a change in pull request #1756:
URL: https://github.com/apache/hive/pull/1756#discussion_r552889107
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AbstractDropPartitionAnalyzer.java
##########
@@ -20,25 +20,17 @@
import java.util.ArrayList;
import java.util.Collection;
-import java.util.HashMap;
Review comment:
All changes in this file are out of scope of the PR. Please revert.
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/misc/msck/MsckAnalyzer.java
##########
@@ -68,7 +68,8 @@ public void analyzeInternal(ASTNode root) throws
SemanticException {
}
Table table = getTable(tableName);
- Map<Integer, List<ExprNodeGenericFuncDesc>> partitionSpecs =
ParseUtils.getFullPartitionSpecs(root, table, conf, false);
+ Map<Integer, List<ExprNodeGenericFuncDesc>> partitionSpecs =
ParseUtils.getFullPartitionSpecs(root, table, conf,
+ false);
Review comment:
All changes in this file are out of scope of the PR. Please revert.
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/AbstractAlterTableOperation.java
##########
@@ -35,7 +35,6 @@
import org.apache.hadoop.hive.ql.ddl.DDLOperationContext;
import org.apache.hadoop.hive.ql.ddl.DDLUtils;
import
org.apache.hadoop.hive.ql.ddl.table.constraint.add.AlterTableAddConstraintOperation;
-import org.apache.hadoop.hive.ql.exec.repl.util.ReplUtils;
Review comment:
All changes in this file are out of scope of the PR. Please revert.
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/lock/show/ShowLocksAnalyzer.java
##########
@@ -26,9 +26,6 @@
import org.apache.hadoop.hive.ql.ddl.DDLWork;
import org.apache.hadoop.hive.ql.exec.Task;
import org.apache.hadoop.hive.ql.exec.TaskFactory;
-import org.apache.hadoop.hive.ql.lockmgr.HiveTxnManager;
-import org.apache.hadoop.hive.ql.lockmgr.LockException;
-import org.apache.hadoop.hive.ql.lockmgr.TxnManagerFactory;
Review comment:
All changes in this file are out of scope of the PR. Please revert.
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MapBuilder.java
##########
@@ -17,51 +17,53 @@
*/
package org.apache.hadoop.hive.ql.metadata.formatting;
-import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.Map;
/**
* Helper class to build Maps consumed by the JSON formatter. Only
* add non-null entries to the Map.
*/
-public class MapBuilder {
- private Map<String, Object> map = new LinkedHashMap<String, Object>();
+public final class MapBuilder {
+ private Map<String, Object> map = new LinkedHashMap<String, Object>();
- private MapBuilder() {}
+ private MapBuilder() {
+ }
- public static MapBuilder create() {
- return new MapBuilder();
- }
+ public static MapBuilder create() {
+ return new MapBuilder();
+ }
- public MapBuilder put(String name, Object val) {
- if (val != null)
- map.put(name, val);
- return this;
+ public MapBuilder put(String name, Object val) {
+ if (val != null) {
+ map.put(name, val);
}
+ return this;
+ }
- public MapBuilder put(String name, boolean val) {
- map.put(name, Boolean.valueOf(val));
- return this;
- }
+ public MapBuilder put(String name, boolean val) {
+ map.put(name, Boolean.valueOf(val));
+ return this;
+ }
- public MapBuilder put(String name, int val) {
- map.put(name, Integer.valueOf(val));
- return this;
- }
+ public MapBuilder put(String name, int val) {
+ map.put(name, Integer.valueOf(val));
+ return this;
+ }
- public MapBuilder put(String name, long val) {
- map.put(name, Long.valueOf(val));
- return this;
- }
+ public MapBuilder put(String name, long val) {
+ map.put(name, Long.valueOf(val));
+ return this;
+ }
- public <T> MapBuilder put(String name, T val, boolean use) {
- if (use)
- put(name, val);
- return this;
+ public <T> MapBuilder put(String name, T val, boolean use) {
+ if (use) {
+ put(name, val);
}
+ return this;
+ }
- public Map<String, Object> build() {
- return map;
- }
+ public Map<String, Object> build() {
+ return map;
+ }
Review comment:
All changes (there are several) in this file are out of scope of the PR.
Please revert.
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/add/AlterTableAddPartitionDesc.java
##########
@@ -234,7 +233,7 @@ public void setWriteId(long writeId) {
@Override
public String getFullTableName() {
- return AcidUtils.getFullTableName(dbName,tableName);
+ return AcidUtils.getFullTableName(dbName, tableName);
Review comment:
All changes in this file are out of scope of the PR. Please revert.
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/process/show/compactions/ShowCompactionsDesc.java
##########
@@ -31,9 +31,11 @@
public class ShowCompactionsDesc implements DDLDesc, Serializable {
private static final long serialVersionUID = 1L;
+ // @formatter:off
public static final String SCHEMA =
"compactionid,dbname,tabname,partname,type,state,hostname,workerid,enqueuetime,starttime,duration,hadoopjobid,errormessage#"
+
"string:string:string:string:string:string:string:string:string:string:string:string:string";
+ // @formatter:on
Review comment:
All changes in this file are out of scope of the PR. Please revert.
I think this is probably an artifact of your IDE.
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/rename/AlterTableRenamePartitionOperation.java
##########
@@ -26,7 +26,6 @@
import org.apache.hadoop.hive.ql.ddl.DDLOperationContext;
import org.apache.hadoop.hive.ql.ddl.DDLUtils;
import org.apache.hadoop.hive.ql.ddl.table.AlterTableUtils;
-import org.apache.hadoop.hive.ql.exec.repl.util.ReplUtils;
Review comment:
All changes in this file are out of scope of the PR. Please revert.
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/lock/show/ShowDbLocksAnalyzer.java
##########
@@ -23,9 +23,6 @@
import org.apache.hadoop.hive.ql.ddl.DDLWork;
import org.apache.hadoop.hive.ql.exec.Task;
import org.apache.hadoop.hive.ql.exec.TaskFactory;
-import org.apache.hadoop.hive.ql.lockmgr.HiveTxnManager;
-import org.apache.hadoop.hive.ql.lockmgr.LockException;
-import org.apache.hadoop.hive.ql.lockmgr.TxnManagerFactory;
Review comment:
All changes in this file are out of scope of the PR. Please revert.
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/constraint/add/AlterTableAddConstraintAnalyzer.java
##########
@@ -79,7 +79,8 @@ protected void analyzeCommand(TableName tableName,
Map<String, String> partition
throw new
SemanticException(ErrorMsg.NOT_RECOGNIZED_CONSTRAINT.getMsg(constraintNode.getToken().getText()));
}
- Constraints constraints = new Constraints(primaryKeys, foreignKeys, null,
uniqueConstraints, null, checkConstraints);
+ Constraints constraints =
+ new Constraints(primaryKeys, foreignKeys, null, uniqueConstraints,
null, checkConstraints);
Review comment:
All changes in this file are out of scope of the PR. Please revert.
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/constraint/drop/AlterTableDropConstraintDesc.java
##########
@@ -83,5 +82,4 @@ public Long getWriteId() {
public boolean mayNeedWriteId() {
return true;
}
-
Review comment:
I believe these changes are out of scope of the PR. Please revert.
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/AlterViewAsAnalyzer.java
##########
@@ -84,7 +84,7 @@ private void validateCreateView(AlterViewAsDesc desc,
SemanticAnalyzer analyzer)
if (oldView == null) {
String viewNotExistErrorMsg = "The following view does not exist: " +
desc.getViewName();
- throw new SemanticException(
ErrorMsg.ALTER_VIEW_AS_SELECT_NOT_EXIST.getMsg(viewNotExistErrorMsg));
+ throw new
SemanticException(ErrorMsg.ALTER_VIEW_AS_SELECT_NOT_EXIST.getMsg(viewNotExistErrorMsg));
Review comment:
All changes in this file are out of scope of the PR. Please revert.
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/skewed/AlterTableSetSkewedLocationAnalyzer.java
##########
@@ -20,7 +20,6 @@
import java.net.URI;
import java.net.URISyntaxException;
-import java.util.ArrayList;
Review comment:
All changes in this file are out of scope of the PR. Please revert.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
