miklosgergely commented on a change in pull request #1914:
URL: https://github.com/apache/hive/pull/1914#discussion_r564800166
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/drop/DropTableDesc.java
##########
@@ -29,31 +32,40 @@
* DDL task description for DROP TABLE commands.
*/
@Explain(displayName = "Drop Table", explainLevels = { Level.USER,
Level.DEFAULT, Level.EXTENDED })
-public class DropTableDesc implements DDLDesc, Serializable {
+public class DropTableDesc implements DDLDescWithWriteId, Serializable {
private static final long serialVersionUID = 1L;
- private final String tableName;
+ private final TableName tableName;
private final boolean ifExists;
private final boolean purge;
private final ReplicationSpec replicationSpec;
private final boolean validationRequired;
+ private final boolean isTransactional;
- public DropTableDesc(String tableName, boolean ifExists, boolean ifPurge,
ReplicationSpec replicationSpec) {
- this(tableName, ifExists, ifPurge, replicationSpec, true);
+ private long writeId = 0;
+
+ public DropTableDesc(TableName tableName, boolean ifExists, boolean ifPurge,
ReplicationSpec replicationSpec) {
+ this(tableName, ifExists, ifPurge, replicationSpec, true, null);
}
- public DropTableDesc(String tableName, boolean ifExists, boolean purge,
ReplicationSpec replicationSpec,
+ public DropTableDesc(TableName tableName, boolean ifExists, boolean ifPurge,
ReplicationSpec replicationSpec,
Review comment:
Nit: the variable name should be purge - I know, it was ifPurge before,
but it's a great opportunity to fix it :)
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/drop/DropTableOperation.java
##########
@@ -104,6 +104,7 @@ public int execute() throws HiveException {
// TODO: API w/catalog name
context.getDb().dropTable(desc.getTableName(), desc.isPurge());
+// context.getDb().dropTable(desc.getTableName(), desc.isPurge(),
desc.getWriteId());
Review comment:
I assume that this was not intentionally left commented out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
