deniskuzZ commented on a change in pull request #1914:
URL: https://github.com/apache/hive/pull/1914#discussion_r565117308
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -1259,6 +1261,43 @@ public boolean dropTable(String catName, String dbName,
String tableName)
return success;
}
+ private void markTableAsPendingDrop(String catName, String dbName, String
tableName) {
+ boolean isLocklessReadsEnabled = MetastoreConf.getBoolVar(getConf(),
ConfVars.LOCKLESS_READS_ENABLED);
+
+ if (isLocklessReadsEnabled) {
+ boolean success = false;
+ tableName = normalizeIdentifier(tableName);
+ dbName = normalizeIdentifier(dbName);
+ catName = normalizeIdentifier(catName);
+ Query query = null;
+
+ try {
+ LOG.debug("Executing markTableAsPendingDrop");
+
+ openTransaction();
Review comment:
Why are you opening new transaction here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
