hmangla98 commented on a change in pull request #2101:
URL: https://github.com/apache/hive/pull/2101#discussion_r605407659



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java
##########
@@ -227,6 +228,12 @@ public long openTxn(Context ctx, String user, TxnType 
txnType) throws LockExcept
     return openTxn(ctx, user, txnType, 0);
   }
 
+  @Override
+  public long openTxn(Context ctx, String user, TxnType txnType, String 
dbUnderReplication) throws LockException {

Review comment:
       repl(Open/Rollback/Commit)Txn is specifically for replayed transaction. 
So, by convention it would be REPL_CREATED transactions. It would be confusion 
if we introduce txnType in that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to