pkumarsinha commented on a change in pull request #2101:
URL: https://github.com/apache/hive/pull/2101#discussion_r608039679
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java
##########
@@ -227,6 +228,12 @@ public long openTxn(Context ctx, String user, TxnType
txnType) throws LockExcept
return openTxn(ctx, user, txnType, 0);
}
+ @Override
+ public long openTxn(Context ctx, String user, TxnType txnType, String
dbUnderReplication) throws LockException {
Review comment:
We can have two paths - one for repl created one for hive repl txn using
same interface and they can differ in the payload(txnType/replPolicy/srcTxnIds.
In current form it would be confusing that which call is supposed to be used
in repl and which is not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
