sankarh commented on a change in pull request #2141:
URL: https://github.com/apache/hive/pull/2141#discussion_r606244819
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/DescTableOperation.java
##########
@@ -148,7 +148,8 @@ private void getColumnsNoColumnPath(Table table, Partition
partition, List<Field
// Fetch partition statistics only for describe extended or formatted.
if (desc.isExtended() || desc.isFormatted()) {
- if (table.isPartitioned() && partition == null) {
+ boolean shouldGetPartStats = MetastoreConf.getBoolVar(context.getConf(),
MetastoreConf.ConfVars.DESCTABLE_ENABLE_PARTITION_STATS);
Review comment:
We need to ensure the stats field itself is removed in the output if
this config is enabled. Also, keep it uniform for both table and partition
stats. Returning incorrect stats misleads user.
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
##########
@@ -559,6 +559,8 @@ public static ConfVars getMetaConf(String name) {
DELEGATION_TOKEN_STORE_CLS("metastore.cluster.delegation.token.store.class",
"hive.cluster.delegation.token.store.class",
METASTORE_DELEGATION_MANAGER_CLASS,
"Class to store delegation tokens"),
+ DESCTABLE_ENABLE_PARTITION_STATS("desctable.enable.partitionstats",
"desctable.enable.partitionstats", true,
Review comment:
This config is used by HS2 and so move it to HiveConf.java. Also, use
the name "hive.describe.table.ignore.stats" and keep the default as false.
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/DescTableOperation.java
##########
@@ -148,7 +148,8 @@ private void getColumnsNoColumnPath(Table table, Partition
partition, List<Field
// Fetch partition statistics only for describe extended or formatted.
if (desc.isExtended() || desc.isFormatted()) {
- if (table.isPartitioned() && partition == null) {
+ boolean shouldGetPartStats = MetastoreConf.getBoolVar(context.getConf(),
MetastoreConf.ConfVars.DESCTABLE_ENABLE_PARTITION_STATS);
+ if (table.isPartitioned() && partition == null && shouldGetPartStats) {
Review comment:
Need to add a unit test to verify the output with and without this
config is set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
