kcheeeung commented on a change in pull request #2141:
URL: https://github.com/apache/hive/pull/2141#discussion_r606607691
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/DescTableOperation.java
##########
@@ -148,7 +148,8 @@ private void getColumnsNoColumnPath(Table table, Partition
partition, List<Field
// Fetch partition statistics only for describe extended or formatted.
if (desc.isExtended() || desc.isFormatted()) {
- if (table.isPartitioned() && partition == null) {
+ boolean shouldGetPartStats = MetastoreConf.getBoolVar(context.getConf(),
MetastoreConf.ConfVars.DESCTABLE_ENABLE_PARTITION_STATS);
+ if (table.isPartitioned() && partition == null && shouldGetPartStats) {
Review comment:
Added the tests. Let me know if I did it right. Here are the steps I did
1. `mvn test -Dtest=TestCliDriver -Dqfile=describe_table.q
-Dtest.output.overwrite=true`
2. It actually made a new output file and was in
`ql/src/test/results/clientpositive/`
3. I saw `describe_table.q.out` in the OSS is actually in a different path
`ql/src/test/results/clientpositive/llap`. What I did was to move the new
output file to the correct location and that's how I got the final diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
