marton-bod commented on a change in pull request #2173:
URL: https://github.com/apache/hive/pull/2173#discussion_r612550849



##########
File path: 
iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -66,6 +74,7 @@
   private boolean deleteIcebergTable;
   private FileIO deleteIo;
   private TableMetadata deleteMetadata;
+  private boolean generateMetadata;

Review comment:
       How about a different naming that reflects that it's related to 
"migratability"? e.g. `boolean canMigrateHiveTable`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to