marton-bod commented on a change in pull request #2173:
URL: https://github.com/apache/hive/pull/2173#discussion_r612577696
##########
File path:
iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -250,4 +312,11 @@ private static PartitionSpec spec(Schema schema,
Properties properties,
return PartitionSpec.unpartitioned();
}
}
+
+ private static class PreAlterTableProperties {
+ private static String tableLocation;
Review comment:
Why make the fields static? I also think it could create concurrency
issues. You could create this as an object similarly to how the
catalogProperties are currently cached in the MetaHook between pre and post
executions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
