ashish-kumar-sharma commented on a change in pull request #2211:
URL: https://github.com/apache/hive/pull/2211#discussion_r626336640
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java
##########
@@ -777,13 +777,14 @@ public ValidTxnList getValidTxns(List<TxnType>
excludeTxnTypes) throws LockExcep
public ValidTxnWriteIdList getValidWriteIds(List<String> tableList,
String validTxnList) throws
LockException {
assert isTxnOpen();
- assert validTxnList != null && !validTxnList.isEmpty();
- try {
- return TxnCommonUtils.createValidTxnWriteIdList(
- txnId, getMS().getValidWriteIds(tableList, validTxnList));
- } catch (TException e) {
- throw new
LockException(ErrorMsg.METASTORE_COMMUNICATION_FAILED.getMsg(), e);
+ if (!StringUtils.isEmpty(validTxnList)) {
Review comment:
When ever validTxnList is null Assert will return false and break the
entire execution loop. Due to which 40 odd UTs are failing. Hence I have to
replace the assert check to simple null check to get the green build.
for list of test failing please check -
http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-2211/7/tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
