ashish-kumar-sharma commented on a change in pull request #2211: URL: https://github.com/apache/hive/pull/2211#discussion_r626394008
########## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java ########## @@ -9479,43 +9479,38 @@ void updateMetrics() throws MetaException { @Override public PrimaryKeysResponse get_primary_keys(PrimaryKeysRequest request) throws TException { - String catName = request.isSetCatName() ? request.getCatName() : getDefaultCatalog(conf); - String db_name = request.getDb_name(); - String tbl_name = request.getTbl_name(); - startTableFunction("get_primary_keys", catName, db_name, tbl_name); + if (!request.isSetCatName()) Review comment: Sure. For now I have replaced it with conditional operator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org