kgyrtkirk commented on a change in pull request #2211: URL: https://github.com/apache/hive/pull/2211#discussion_r632473124
########## File path: standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift ########## @@ -701,6 +705,8 @@ struct UniqueConstraintsRequest { 1: required string catName, 2: required string db_name, 3: required string tbl_name, + 4: optional string validWriteIdList, + 5: optional i64 tableId=-1 Review comment: I wonder if a common object to reference a table might be handy ; these 5 fields are copied to a bunch of requests/responses - having a common object might make it easier to work with them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org