ashish-kumar-sharma commented on a change in pull request #2211:
URL: https://github.com/apache/hive/pull/2211#discussion_r633090240
##########
File path:
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -701,6 +705,8 @@ struct UniqueConstraintsRequest {
1: required string catName,
2: required string db_name,
3: required string tbl_name,
+ 4: optional string validWriteIdList,
+ 5: optional i64 tableId=-1
Review comment:
@kgyrtkirk I initially though the same. But doing this change will break
the metastore api contract and all call from HiveMetaStoreClient.java from
older clients will not be compatible any more. So that's why instead of
extracting out the common variable to another struct I added in the same as
optional.
##########
File path:
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -690,7 +692,9 @@ struct ForeignKeysRequest {
2: string parent_tbl_name,
3: string foreign_db_name,
4: string foreign_tbl_name
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
