pvary commented on a change in pull request #1998:
URL: https://github.com/apache/hive/pull/1998#discussion_r633430432
##########
File path:
service/src/java/org/apache/hive/service/cli/session/SessionManager.java
##########
@@ -281,6 +284,7 @@ private void initOperationLogRootDir() {
LOG.warn("Failed to schedule cleanup HS2 operation logging root dir: "
+
operationLogRootDir.getAbsolutePath(), e);
}
+ logManager = new OperationLogManager(this, hiveConf);
Review comment:
Do we need the `OperationLogManager` if we do not use async log removal?
Could we use `Optional` for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
