dengzhhu653 commented on a change in pull request #1998:
URL: https://github.com/apache/hive/pull/1998#discussion_r633643084
##########
File path:
service/src/java/org/apache/hive/service/cli/operation/OperationManager.java
##########
@@ -85,10 +79,7 @@ public synchronized void init(HiveConf hiveConf) {
LogDivertAppender.registerRoutingAppender(hiveConf);
LogDivertAppenderForTest.registerRoutingAppenderIfInTest(hiveConf);
- if (hiveConf.isWebUiQueryInfoCacheEnabled()) {
- historicalQueryInfos = new QueryInfoCache(
- hiveConf.getIntVar(ConfVars.HIVE_SERVER2_WEBUI_MAX_HISTORIC_QUERIES));
- }
+ this.queryInfoCache = new QueryInfoCache(hiveConf);
Review comment:
yes, the cache will only be used when the WebUI is enabled, make it
Optional here.
##########
File path:
service/src/java/org/apache/hive/service/cli/session/SessionManager.java
##########
@@ -281,6 +284,7 @@ private void initOperationLogRootDir() {
LOG.warn("Failed to schedule cleanup HS2 operation logging root dir: "
+
operationLogRootDir.getAbsolutePath(), e);
}
+ logManager = new OperationLogManager(this, hiveConf);
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
