pgaref commented on a change in pull request #2310:
URL: https://github.com/apache/hive/pull/2310#discussion_r637382760
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java
##########
@@ -313,17 +307,13 @@ public void configure(JobConf job) {
public static boolean checkInputFormatForLlapEncode(Configuration conf,
String ifName) {
String formatList = HiveConf.getVar(conf, ConfVars.LLAP_IO_ENCODE_FORMATS);
- if (LOG.isDebugEnabled()) {
- LOG.debug("Checking " + ifName + " against " + formatList);
- }
+ LOG.debug("Checking {} against {}", ifName, formatList);
String[] formats = StringUtils.getStrings(formatList);
if (formats != null) {
for (String format : formats) {
// TODO: should we check isAssignableFrom?
if (ifName.equals(format)) {
- if (LOG.isInfoEnabled()) {
- LOG.info("Using SerDe-based LLAP reader for " + ifName);
- }
+ LOG.info("Using SerDe-based LLAP reader for " + ifName);
Review comment:
Using SerDe-based LLAP reader for {}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
