[GitHub] [hive] pgaref commented on a change in pull request #2310: HIVE-25152: Remove Superfluous Logging Code

[GitBox]

pgaref commented on a change in pull request #2310:
URL: https://github.com/apache/hive/pull/2310#discussion_r637382893



##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java
##########
@@ -1463,15 +1441,11 @@ public Object process(Node nd, Stack<Node> stack, 
NodeProcessorCtx ctx, Object..
           ndRecursive = ndRecursive.getChildren().get(0);
         }
         if (ndRecursive.getChildren().get(0) instanceof ReduceSinkOperator) {
-          if (LOG.isDebugEnabled()) {
-            LOG.debug("Skip JOIN-FIL(*)-RS structure.");
-          }
+          LOG.debug("Skip JOIN-FIL(*)-RS structure.");
           return null;
         }
       }
-      if (LOG.isInfoEnabled()) {
-        LOG.info("Old exprs " + conf.getExprs());
-      }
+      LOG.info("Old exprs " + conf.getExprs());

Review comment:
       Old exprs {}

##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java
##########
@@ -1484,18 +1458,14 @@ public Object process(Node nd, Stack<Node> stack, 
NodeProcessorCtx ctx, Object..
         for (ExprNodeDesc expr : exprs) {
           ExprNodeDesc newExpr = foldExpr(expr, constants, cppCtx, op, tag, 
false);
           if (newExpr instanceof ExprNodeConstantDesc) {
-            if (LOG.isInfoEnabled()) {
-              LOG.info("expr " + newExpr + " fold from " + expr + " is 
removed.");
-            }
+            LOG.info("expr " + newExpr + " fold from " + expr + " is 
removed.");

Review comment:
       same

##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java
##########
@@ -1484,18 +1458,14 @@ public Object process(Node nd, Stack<Node> stack, 
NodeProcessorCtx ctx, Object..
         for (ExprNodeDesc expr : exprs) {
           ExprNodeDesc newExpr = foldExpr(expr, constants, cppCtx, op, tag, 
false);
           if (newExpr instanceof ExprNodeConstantDesc) {
-            if (LOG.isInfoEnabled()) {
-              LOG.info("expr " + newExpr + " fold from " + expr + " is 
removed.");
-            }
+            LOG.info("expr " + newExpr + " fold from " + expr + " is 
removed.");
             continue;
           }
           newExprs.add(newExpr);
         }
         e.setValue(newExprs);
       }
-      if (LOG.isInfoEnabled()) {
-        LOG.info("New exprs " + conf.getExprs());
-      }
+      LOG.info("New exprs " + conf.getExprs());

Review comment:
       same




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org