belugabehr commented on pull request #2310:
URL: https://github.com/apache/hive/pull/2310#issuecomment-846426813
@pgaref Thank you so much for your interest in this.
I do not believe the requested changes will yield any value. The two
reasons one would use the anchors `{}` in SLF4J is twofold:
1. Readability (String formatting and no need for boilerplate logging guards)
2. Performance when _not_ logging
This PR is simply to remove superfluous code that does not add any
measurable value and makes the code harder to read. I don't want to be adding
in new code changes if I can help it.
With that said, in any production environment, the logging level will always
be _at least_: INFO, WARN, ERROR. Therefore, there is no need to ever care
about performance of INFO messages. It is _assumed_ that they will always be
printed, so there is no need to add logging guards (`if (Log.isInfoEnabled())`)
and there is no need for anchors. Again, anchors are nice for readability, but
I don't want to modify the existing INFO level logging too much; that is
another exercise for another PR if someone is truly inclined. I think it's
better to just stop introducing this superfluous code moving forward and the
old stuff will eventually be updated.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
