[GitHub] [hive] pgaref commented on a change in pull request #2310: HIVE-25152: Remove Superfluous Logging Code

[GitBox]

pgaref commented on a change in pull request #2310:
URL: https://github.com/apache/hive/pull/2310#discussion_r637383222



##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/exec/AppMasterEventOperator.java
##########
@@ -137,10 +134,8 @@ public void closeOp(boolean abort) throws HiveException {
           InputInitializerEvent.create(vertexName, inputName,
               ByteBuffer.wrap(payload, 0, payload.length));
 
-      if (LOG.isInfoEnabled()) {
-        LOG.info("Sending Tez event to vertex = " + vertexName + ", input = " 
+ inputName
-          + ". Payload size = " + payload.length);
-      }
+      LOG.info("Sending Tez event to vertex = " + vertexName + ", input = " + 
inputName + ". Payload size = "

Review comment:
       same

##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java
##########
@@ -391,9 +391,7 @@ protected void initializeOp(Configuration hconf) throws 
HiveException {
       }
     }
 
-    if (LOG.isInfoEnabled()) {
-      LOG.info("JOIN " + outputObjInspector.getTypeName() + " totalsz = " + 
totalSz);
-    }
+    LOG.info("JOIN " + outputObjInspector.getTypeName() + " totalsz = " + 
totalSz);

Review comment:
       same

##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/DemuxOperator.java
##########
@@ -185,10 +185,7 @@ protected void initializeOp(Configuration hconf) throws 
HiveException {
       }
       newChildOperatorsTag[i] = toArray(childOperatorTags);
     }
-    if (LOG.isInfoEnabled()) {
-      LOG.info("newChildOperatorsTag " + 
Arrays.toString(newChildOperatorsTag));
-    }
-
+    LOG.info("newChildOperatorsTag " + Arrays.toString(newChildOperatorsTag));

Review comment:
       same




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org