dantongdong commented on a change in pull request #2371:
URL: https://github.com/apache/hive/pull/2371#discussion_r651962841
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -3799,10 +3799,33 @@ public Table get_table_core(GetTableRequest
getTableRequest) throws MetaExceptio
@Override
public GetTablesResult get_table_objects_by_name_req(GetTablesRequest req)
throws TException {
String catName = req.isSetCatName() ? req.getCatName() :
getDefaultCatalog(conf);
+ if (isDatabaseRemote(req.getDbName())) {
+ return new
GetTablesResult(getRemoteTableObjectsInternal(req.getDbName(),
req.getTblNames(), req.getTablesPattern()));
+ }
return new GetTablesResult(getTableObjectsInternal(catName,
req.getDbName(),
req.getTblNames(), req.getCapabilities(), req.getProjectionSpec(),
req.getTablesPattern()));
}
+ private String tableNames2regex(List<String> tableNames) {
+ return "/^(" + String.join("|", tableNames) + ")$/";
Review comment:
Good catch. Will look into that. As a side note, it seems that at least
mysql does not like ".*" to be passed in as a regex getTable API call and will
throw an error. I have to manually changed the regex to null, is it normal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
