dantongdong commented on a change in pull request #2371:
URL: https://github.com/apache/hive/pull/2371#discussion_r658196105
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/AbstractJDBCConnectorProvider.java
##########
@@ -53,7 +53,6 @@
private static final String JDBC_OUTPUTFORMAT_CLASS =
"org.apache.hive.storage.jdbc.JdbcOutputFormat".intern();
String type = null; // MYSQL, POSTGRES, ORACLE, DERBY, MSSQL, DB2 etc.
- String driverClassName = null;
Review comment:
AbstractJDBCConnectorProvider Class extends
AbstractDataConnectorProvider(super) Class. driverClassName is already a field
in the super class. Having driverClassName=null here will overwrite the passed
in driverClassName by specific provider, as AbstractJDBCConnectorProvider
constructor is calling its super class constructor. This line is the root cause
of "Could not find a provider for remote database" error. Removing the line
will stop the overwritten problem. All the provider can set driverClassName via
calling AbstractDataConnectorProvider's constructor, which is what
AbstractJDBCConnectorProvider is doing for all the providers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
