ShubhamChaurasia commented on a change in pull request #2391:
URL: https://github.com/apache/hive/pull/2391#discussion_r655432446
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/arrow/Serializer.java
##########
@@ -347,6 +347,21 @@ private void writeStruct(NonNullableStructVector
arrowVector, StructColumnVector
final ColumnVector[] hiveFieldVectors = hiveVector == null ? null :
hiveVector.fields;
final int fieldSize = fieldTypeInfos.size();
+ // This is to handle following scenario -
+ // if any struct value itself is NULL, we get structVector.isNull[i]=true
+ // but we don't get the same for it's child fields which later causes
exceptions while setting to arrow vectors
+ // see - https://issues.apache.org/jira/browse/HIVE-25243
+ if (hiveVector != null && hiveFieldVectors != null) {
+ for (int i = 0; i < size; i++) {
+ if (hiveVector.isNull[i]) {
+ for (ColumnVector fieldVector : hiveFieldVectors) {
+ fieldVector.isNull[i] = true;
Review comment:
It is like - if for outer vector(struct here) isNull[i] = true, all the
nested vectors (hiveFieldVectors) should also have isNull[i] = true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
