ShubhamChaurasia commented on a change in pull request #2391:
URL: https://github.com/apache/hive/pull/2391#discussion_r655425247
##########
File path:
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniLlapVectorArrow.java
##########
@@ -238,7 +238,10 @@ public void testDataTypes() throws Exception {
assertEquals(Date.valueOf("2013-01-01"), rowValues[19]);
assertEquals("abc123", rowValues[20]);
assertEquals("abc123 ", rowValues[21]);
- assertArrayEquals("X'01FF'".getBytes("UTF-8"), (byte[]) rowValues[22]);
+
+ // one of the above assertions already has assertEquals(null,
rowValues[22])
+ // and below assertion fails with - java.lang.AssertionError: actual array
was null
+ // assertArrayEquals("X'01FF'".getBytes("UTF-8"), (byte[]) rowValues[22]);
Review comment:
ah yes, right I missed that, will create a new test altogether for this
as suggested in other comments too.
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/arrow/Serializer.java
##########
@@ -347,6 +347,21 @@ private void writeStruct(NonNullableStructVector
arrowVector, StructColumnVector
final ColumnVector[] hiveFieldVectors = hiveVector == null ? null :
hiveVector.fields;
final int fieldSize = fieldTypeInfos.size();
+ // This is to handle following scenario -
+ // if any struct value itself is NULL, we get structVector.isNull[i]=true
+ // but we don't get the same for it's child fields which later causes
exceptions while setting to arrow vectors
+ // see - https://issues.apache.org/jira/browse/HIVE-25243
+ if (hiveVector != null && hiveFieldVectors != null) {
+ for (int i = 0; i < size; i++) {
+ if (hiveVector.isNull[i]) {
+ for (ColumnVector fieldVector : hiveFieldVectors) {
+ fieldVector.isNull[i] = true;
Review comment:
It is like - if for outer vector(struct here) isNull[i] = true, all the
nested vectors (hiveFieldVectors) should also have isNull[i] = true.
##########
File path:
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestMiniLlapVectorArrowWithLlapIODisabled.java
##########
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hive.jdbc;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.conf.HiveConf.ConfVars;
+import org.apache.hadoop.hive.llap.LlapArrowRowInputFormat;
+import org.apache.hadoop.hive.llap.Row;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.mapred.InputFormat;
+import org.junit.BeforeClass;
+import org.junit.Ignore;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+
+/**
+ * TestMiniLlapVectorArrowWithLlapIODisabled - turns off llap io while testing
LLAP external client flow.
+ * The aim of turning off LLAP IO is -
+ * when we create table through this test, LLAP caches them and returns the
same
Review comment:
By default, LLAP IO is ON in default mini-llap conf, this issue is only
seen when we turn it off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
