dengzhhu653 commented on pull request #2344: URL: https://github.com/apache/hive/pull/2344#issuecomment-910165905
> Thanks for catching this! > > We should close all the queries, even if there is an exception. > Since Java 8 closing queries in `try-with-resources` would be the best if possible, falling back to `finally` when not possible is the second best. Thank you for the review! Introduces a new QueryWrapper to avoid superfluous exception handing when using `try-with-resources` with the class `Query` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
