pvary commented on a change in pull request #2344:
URL: https://github.com/apache/hive/pull/2344#discussion_r702681959
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
##########
@@ -2107,15 +2115,17 @@ private ColumnStatisticsObj
prepareCSObjWithAdjustedNDV(Object[] row, int i,
makeParams(inputColNames.size()),
makeParams(inputPartNames.size()));
long start = doTrace ? System.nanoTime() : 0;
Query query = pm.newQuery("javax.jdo.query.SQL", queryText);
- Object qResult = executeWithArray(query, prepareParams(
- catName, dbName, tableName, inputPartNames, inputColNames,
engine), queryText);
- MetastoreDirectSqlUtils.timingTrace(doTrace, queryText0, start,
(doTrace ? System.nanoTime() : 0));
- if (qResult == null) {
- query.closeAll();
- return Collections.emptyList();
+ try {
Review comment:
I think `addQueryAfterUse` is there for closing the queries. So we might
not need them anymore. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
