harishjp commented on a change in pull request #2639:
URL: https://github.com/apache/hive/pull/2639#discussion_r720588725
##########
File path:
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcFileStripeMergeRecordReader.java
##########
@@ -63,8 +63,20 @@ public void testSplitStartsWithOffset() throws IOException {
FileSplit split = new FileSplit(tmpPath, offset, length, (String[])null);
OrcFileStripeMergeRecordReader reader = new
OrcFileStripeMergeRecordReader(conf, split);
reader.next(key, value);
+ // since offset is non-zero this file will not be processed.
+ Assert.assertNull(key.getInputPath());
+ split = new FileSplit(tmpPath, 0, length, (String[]) null);
Review comment:
The code is fine but confusing, changed to 2 test classes to make it
simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
