harishjp commented on a change in pull request #2639:
URL: https://github.com/apache/hive/pull/2639#discussion_r723577374
##########
File path:
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcFileStripeMergeRecordReader.java
##########
@@ -34,7 +35,7 @@
public class TestOrcFileStripeMergeRecordReader {
- private final int DEFAULT_STRIPE_SIZE = 5000;
+ private static final int DEFAULT_STRIPE_SIZE = 5000;
Review comment:
I think this is just a test stripe size, creating 64k rows in test is
too much when it does not provide any extra benefits. I think some arbitrary
default was chosen. The name is definitely misleading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
