pvary commented on a change in pull request #2701:
URL: https://github.com/apache/hive/pull/2701#discussion_r724384466
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java
##########
@@ -491,11 +534,29 @@ private static void createFileForCommit(DataFile[]
closedFiles, String location,
LOG.debug("Iceberg committed file is created {}", fileForCommit);
}
+ private static void createDeleteFileForCommit(DeleteFile[] closedFiles,
String location, FileIO io)
+ throws IOException {
+
+ OutputFile fileForCommit = io.newOutputFile(location);
+ try (ObjectOutputStream oos = new
ObjectOutputStream(fileForCommit.createOrOverwrite())) {
+ oos.writeObject(closedFiles);
+ }
+ LOG.debug("Iceberg committed file is created {}", fileForCommit);
Review comment:
nit: maybe a different commit message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
