pvary commented on a change in pull request #2701:
URL: https://github.com/apache/hive/pull/2701#discussion_r724783521
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergRecordWriter.java
##########
@@ -64,13 +76,20 @@
return writers.get(taskAttemptID);
}
- HiveIcebergRecordWriter(Schema schema, PartitionSpec spec, FileFormat format,
+ HiveIcebergRecordWriter(
+ Schema schema, PartitionSpec spec, FileFormat format,
FileAppenderFactory<Record> appenderFactory, OutputFileFactory
fileFactory, FileIO io, long targetFileSize,
- TaskAttemptID taskAttemptID, String tableName) {
+ TaskAttemptID taskAttemptID, String tableName, boolean isDelete) {
Review comment:
Should we create a different writer for delete-s?
It could inherit from `RollingPositionDeleteWriter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
