vihangk1 commented on a change in pull request #2730:
URL: https://github.com/apache/hive/pull/2730#discussion_r731302621
##########
File path: metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -2565,34 +2566,68 @@ private Collection getPartitionPsQueryResults(String
dbName, String tableName,
return (Collection) query.execute(dbName, tableName, partNameMatcher);
}
+ /**
+ * If partVals all the values are empty strings, it means we are returning
+ * all the partitions and hence we can attempt to use a directSQL equivalent
API which
+ * is considerably faster.
+ * @param partVals The partitions values used to filter out the partitions.
+ * @return true if partVals is empty or if all the values in partVals is
empty strings.
Review comment:
I know this is from the original patch but looks like this javadoc is
incorrect. The method actually returns false if partVals is empty. I don't
really remember now why that was the case. Perhaps you can look at this if you
have some cycles? If not, please fix the java doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
