vihangk1 commented on a change in pull request #2730:
URL: https://github.com/apache/hive/pull/2730#discussion_r731326469
##########
File path: metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -2571,8 +2571,8 @@ private Collection getPartitionPsQueryResults(String
dbName, String tableName,
* all the partitions and hence we can attempt to use a directSQL equivalent
API which
* is considerably faster.
* @param partVals The partitions values used to filter out the partitions.
- * @return true if partVals is empty or if all the values in partVals is
empty strings.
- * other wise false. If user or groups is valid then returns false since the
directSQL
+ * @return false if partVals is empty, true if all the values in partVals
are empty strings and
Review comment:
the comment should be "...and otherwise false for all the other cases"
Or more simply, the method returns true only when partVals is non-empty and
contains only empty strings, otherwise false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
