pkumarsinha commented on a change in pull request #2724:
URL: https://github.com/apache/hive/pull/2724#discussion_r742587970
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/metric/ReplicationMetricCollector.java
##########
@@ -116,14 +136,16 @@ public void reportStageEnd(String stageName, Status
status, long lastReplId,
stage = new Stage(stageName, status, -1L);
}
stage.setStatus(status);
- stage.setEndTime(System.currentTimeMillis());
+ stage.setEndTime(getCurrentTimeInMillis());
stage.setReplSnapshotsCount(replSnapshotCount);
if (replStatsTracker != null && !(replStatsTracker instanceof
NoOpReplStatsTracker)) {
String replStatString = replStatsTracker.toString();
LOG.info("Replication Statistics are: {}", replStatString);
stage.setReplStats(replStatString);
}
progress.addStage(stage);
+ // Check the progress string doesn't surpass the RM_PROGRESS column
width.
+ checkRMProgressLimit(progress, stage);
Review comment:
nit:
it's not just check. it is updating the state as well. we should name it
accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
