pkumarsinha commented on a change in pull request #2724:
URL: https://github.com/apache/hive/pull/2724#discussion_r744446628
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/metric/ReplicationMetricCollector.java
##########
@@ -105,6 +110,21 @@ public void reportFailoverStart(String stageName,
Map<String, Long> metricMap,
}
}
+ private void updateRMProgressIfLimitExceeds(Progress progress, Stage stage)
throws SemanticException {
+ MessageSerializer serializer =
MessageFactory.getDefaultInstanceForReplMetrics(conf).getSerializer();
+ ObjectMapper mapper = new ObjectMapper();
+ String serializedProgress = null;
+ try {
+ serializedProgress =
serializer.serialize(mapper.writeValueAsString(progress));
+ } catch (Exception e) {
+ throw new SemanticException(e);
+ }
+ if (serializedProgress.length() > ReplStatsTracker.RM_PROGRESS_LENGTH) {
+ stage.setReplStats("Error: RM_PROGRESS limit exceeded to " +
serializedProgress.length());
Review comment:
Also, please add the dropped progress as a part of log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
