kgyrtkirk commented on a change in pull request #2545:
URL: https://github.com/apache/hive/pull/2545#discussion_r756085431
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java
##########
@@ -910,12 +910,12 @@ private void updateDPCounters(final FSPaths fsp, final
int filesIdx) {
}
private void createDpDirCheckSrc(final Path dpStagingPath, final Path
dpFinalPath) throws IOException {
- if (!fs.exists(dpStagingPath) && !fs.exists(dpFinalPath)) {
Review comment:
I don't fully understand why we had `dpFinalPath` as a parameter to this
method; and why was it also checked before creating the `dpStagingPath` => if
`dpFinalPath` was already existed the staging dir was not created....I don't
know if that was a bug or intentional....
but now this `dpFinalPath` also become unused; so it could be removed from
the function signature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
