kgyrtkirk commented on a change in pull request #2545:
URL: https://github.com/apache/hive/pull/2545#discussion_r756090246
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java
##########
@@ -910,12 +910,12 @@ private void updateDPCounters(final FSPaths fsp, final
int filesIdx) {
}
private void createDpDirCheckSrc(final Path dpStagingPath, final Path
dpFinalPath) throws IOException {
- if (!fs.exists(dpStagingPath) && !fs.exists(dpFinalPath)) {
Review comment:
if we remove the extra argument we get the same method as `createDpDir`
- so there must have been a reason for that if in
[HIVE-17778](https://github.com/apache/hive/commit/a9f25c0e7ad3f81a9f00f601947a161516e33f1b#diff-75a40b9ea37fdd5cad43bb2690f796ab678e2c7cf92be78f8de150b3f3c0d98dR819)
an extra if and these 2 methods were added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
