deniskuzZ commented on a change in pull request #2772:
URL: https://github.com/apache/hive/pull/2772#discussion_r760168937
##########
File path:
standalone-metastore/metastore-common/src/gen/thrift/gen-cpp/hive_metastore_types.cpp
##########
@@ -615,16 +615,18 @@ int _kTxnTypeValues[] = {
TxnType::REPL_CREATED,
TxnType::READ_ONLY,
TxnType::COMPACTION,
- TxnType::MATER_VIEW_REBUILD
+ TxnType::MATER_VIEW_REBUILD,
+ TxnType::SOFT_DELETE
Review comment:
Old versions of HMS would treat new values as null (default - null), in
this case, we won't ever enter the if branch for SOFT_DELETE, meaning, we won't
populate the highest write id required by cleaner and might clean up some
deltas prematurely, see HIVE-24291.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
